Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @cxznmhdcxz, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
This PR adds a command usage example to the providerhub sku nested-resource-type-third create command documentation to improve user guidance.
- Adds an example section to the command's docstring showing how to create a SKU with nested resource types
| """Create the resource type skus in the given resource type. | ||
|
|
||
| :example: Create a sku in the resource type. | ||
| az providerhub sku nested-resource-type-third create --provider-namespace Microsoft.Contoso --resource-type testResourceType --nested-resource-type-first nestedResourceTypeFirst --nested-resource-type-second nestedResourceTypeSecond --nested-resource-type-third nestedResourceTypeThird --name testSku --sku-settings "[{name:freeSku,tier:Tier1,kind:Standard},{name:premiumSku,tier:Tier2,kind:Premium,costs:[{meter-id:xxx}]}]" |
There was a problem hiding this comment.
The JSON in the --sku-settings parameter is malformed. Property names should be quoted. The correct format should be: --sku-settings "[{"name":"freeSku","tier":"Tier1","kind":"Standard"},{"name":"premiumSku","tier":"Tier2","kind":"Premium","costs":[{"meter-id":"xxx"}]}]"
| az providerhub sku nested-resource-type-third create --provider-namespace Microsoft.Contoso --resource-type testResourceType --nested-resource-type-first nestedResourceTypeFirst --nested-resource-type-second nestedResourceTypeSecond --nested-resource-type-third nestedResourceTypeThird --name testSku --sku-settings "[{name:freeSku,tier:Tier1,kind:Standard},{name:premiumSku,tier:Tier2,kind:Premium,costs:[{meter-id:xxx}]}]" | |
| az providerhub sku nested-resource-type-third create --provider-namespace Microsoft.Contoso --resource-type testResourceType --nested-resource-type-first nestedResourceTypeFirst --nested-resource-type-second nestedResourceTypeSecond --nested-resource-type-third nestedResourceTypeThird --name testSku --sku-settings "[{\"name\":\"freeSku\",\"tier\":\"Tier1\",\"kind\":\"Standard\"},{\"name\":\"premiumSku\",\"tier\":\"Tier2\",\"kind\":\"Premium\",\"costs\":[{\"meter-id\":\"xxx\"}]}]" |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @cxznmhdcxz Release SuggestionsModule: providerhub
Notes
|
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.